[patch] unbreak KdEnableInput

Peter Hutterer peter.hutterer at who-t.net
Mon Oct 14 16:15:02 PDT 2013


On Wed, Oct 09, 2013 at 05:16:18PM -0500, Strake wrote:
> Segfault otherwise.
> 
> From 7bc2543ee36e46fedfea3f0af6042be3667e88d2 Mon Sep 17 00:00:00 2001
> From: Strake <strake888 at gmail.com>
> Date: Wed, 9 Oct 2013 11:36:34 -0500
> Subject: [PATCH] unbreak KdEnableInput
> 

please sign off your patches, see
http://www.x.org/wiki/Development/Documentation/SubmittingPatches/

> ---
>  hw/kdrive/src/kinput.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/kdrive/src/kinput.c b/hw/kdrive/src/kinput.c
> index 527c7a2..c49f2e0 100644
> --- a/hw/kdrive/src/kinput.c
> +++ b/hw/kdrive/src/kinput.c
> @@ -320,8 +320,8 @@ KdEnableInput(void)
> 
>      /* reset screen saver */
>      ev.any.time = GetTimeInMillis();
> -    NoticeEventTime(&ev, pi->dixdev);
> -    NoticeEventTime(&ev, ki->dixdev);
> +    if (kdPointers)  NoticeEventTime(&ev, kdPointers ->dixdev);

no space before ->

> +    if (kdKeyboards) NoticeEventTime(&ev, kdKeyboards->dixdev);

shouldn't this be moved up into the respective loop? otherwise you're only
updating the event time for the first device in the list.

Cheers,
   Peter

> 
>      OsReleaseSIGIO();
>  }
> -- 
> 1.7.11.1


More information about the xorg-devel mailing list