[PATCH 2/4] glx: Fix memory leak in context garbage collection (v2)

Mouse mouse at Rodents-Montreal.ORG
Tue Oct 8 11:22:35 PDT 2013


>>>> -    ctx->isCurrent = False;
>>>> +    ctx->currentClient = False;

>> Should this maybe be 0 instead of False?

> Good catch.  It's just luck that False is #defined as 0. :)  It
> should, of course, be NULL.

Well, I'd actually disagree; I think NULL should never be used - see my
blah post of 2009-10-09
(http://ftp.rodents-montreal.org/mouse/blah/2009-10-09-1.html) for why.

I do, however, agree that NULL, for all its problems, is better than
False in this usage. :-)

/~\ The ASCII				  Mouse
\ / Ribbon Campaign
 X  Against HTML		mouse at rodents-montreal.org
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B


More information about the xorg-devel mailing list