[PATCH 16/19] glx: Remove screen number from __GLXconfig

Adam Jackson ajax at redhat.com
Mon Oct 7 14:44:38 PDT 2013


On Sun, 2013-10-06 at 17:24 +0100, Jon TURNEY wrote:
> On 21/08/2013 22:25, Adam Jackson wrote:
> > Not used.  There's no real reason to match against this instead of
> > matching against fbconfig or visual ID anyway.
> > 
> > Signed-off-by: Adam Jackson <ajax-H+wXaHxf7aLQT0dZR+AlfA at public.gmane.org>
> > ---
> >  glx/glxscreens.h | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/glx/glxscreens.h b/glx/glxscreens.h
> > index 19a2599..c8119fd 100644
> > --- a/glx/glxscreens.h
> > +++ b/glx/glxscreens.h
> > @@ -92,8 +92,6 @@ struct __GLXconfig {
> >      /* OML_swap_method */
> >      GLint swapMethod;
> >  
> > -    GLint screen;
> > -
> >      /* EXT_texture_from_pixmap */
> >      GLint bindToTextureRgb;
> >      GLint bindToTextureRgba;
> > 
> 
> Not used, but was being set in hw/xwin/glx, so that needs to be removed as well.

Erk, apologies, yes.  It's a little odd that that code mentions
EXT_import_context, I can see why it might but the corresponding code in
QueryContext has just looked it up from ->pScreen->myNum since at least
Xorg 6.7.  Still:

Reviewed-by: Adam Jackson <ajax at redhat.com>

- ajax



More information about the xorg-devel mailing list