[PATCH] OS/ACPI: Make socket to acpid is non-blocking

[Egbert Eich]

On Fri, Oct 04, 2013 at 04:14:29PM -0700, Keith Packard wrote:
> Egbert Eich <eich at freedesktop.org> writes:
> 
> > If a connect to the acpid socket is delayed connect will
> > hang stalling the Xserver.  To avoid this this create a
> > non-blocking socket.
> 
> Do you have cases which actually cause a delay in this case? Seems like
> acpid shouldn't be significantly delayed in responding to connect
> requests...

We received a backtrace from a partner that clearly showed that the
Xserver was stuck in the connect call after a resume from S4.
Unfortunately we have never been able to obtain sufficient information 
to get down to the root cause. 
What we did learn however was, that a proprietary driver stack was use 
and that the previous version of this stack had set xf86acpiDisableFlag 
to false thus this connect never got called. This version had never 
experienced any hang.

We then changed the connect to non-blocking and implemented the retry 
sceme and have been carrying this patch since. I'm not aware of any
similar problems after that.

Cheers,
	Egbert.