[PATCH] DDX/modes: Add a sanity check when using screen sizes from EDID

Keith Packard keithp at keithp.com
Fri Oct 4 14:25:53 PDT 2013


Egbert Eich <eich at freedesktop.org> writes:

> EDID sometimes lies about screen sizes. Since the screen size is used
> by clients to determine the DPI a wrong ration will lead to terrible
> looking fonts.
> Add a sanity check for the h/v ratio cutting off at 2.4. This would
> still accept the cinemascope aspect ratio as valid.
> Also add message suggesting to add a quirk table entry.

Please do this without division so that we don't have to think about
whether the values might be zero or not.

        h / v > 2.4
        h > 2.4 * v

        5 * h > 12 * v

similarly:
        
        5 * v > 12 * h

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131004/f84fd0c8/attachment-0001.pgp>


More information about the xorg-devel mailing list