[PATCH video-ati] Revert "radeon: enable glamor by default (v4)"

Gaetan Nadon memsize at videotron.ca
Wed Oct 2 14:13:00 PDT 2013


This reverts commit 282587cd0709850e7bacb1d8307065d95dc2c97d.

Requiring the glamor package by default breaks the build as this package
contains development files and is generally not installed by default in distros.

It also goes against user expectations that the X source tree can be built
out of the box without having to set configure options.

Moreover, the package is only available on a few very recent distros, for
example Ubuntu saucy 13.10. The package name is libglamor-dev.

/usr/include/xorg/glamor.h
/usr/lib/x86_64-linux-gnu/libglamor.so
/usr/lib/x86_64-linux-gnu/pkgconfig/glamor-egl.pc
/usr/lib/x86_64-linux-gnu/pkgconfig/glamor.pc
/usr/share/doc/libglamor-dev/changelog.Debian.gz
/usr/share/doc/libglamor-dev/copyright

My assumption is that the dev package is not required at run time but only
required for ati driver developers who are writing code against glamor.

Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
---
	
	There is no .pc file for runtime time package, so I don't know how you
can tell if it is installed or not. Perhaps other distros don't make a 
distinction and lump all files together.

Here is the link to the three Ubuntu packages:

http://packages.ubuntu.com/search?keywords=glamor&searchon=names&suite=all&section=all

I don't have a good enough understanding to propose a patch for a real solution
if all my assumptions are correct.

 configure.ac |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 0fe0991..8b83a7c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -100,10 +100,10 @@ CPPFLAGS="$CPPFLAGS $XORG_CFLAGS"
 
 AC_MSG_CHECKING([whether to include GLAMOR support])
 AC_ARG_ENABLE(glamor,
-	      AS_HELP_STRING([--disable-glamor],
-			     [Disable glamor, a new GL-based acceleration [default=enabled]]),
+	      AS_HELP_STRING([--enable-glamor],
+			     [Enable glamor, a new GL-based acceleration [default=no]]),
 	      [GLAMOR="$enableval"],
-	      [GLAMOR=yes])
+	      [GLAMOR=no])
 AC_MSG_RESULT([$GLAMOR])
 AM_CONDITIONAL(GLAMOR, test x$GLAMOR != xno)
 if test "x$GLAMOR" != "xno"; then
-- 
1.7.9.5



More information about the xorg-devel mailing list