[PATCH] [RFC] socket activation code for xserver

[Hans de Goede]

Hi Łukasz,

So I was taking a closer look at the libxtrans patch today,
and I noticed that it does not build. It adds a check for
trans->flags&TRANS_RECEIVED inside the main loop in
MakeAllCOTSServerListeners. But TRANS_RECEIVED does not get
defined anywhere.

I've added a define for it to Xtransint.h, which fixes the
build issue. But other then fixing the BuildIssue this
makes little sense, since the flag is never being set.

So an alternative approach to fixing the build issue, would
to just remove the addition of the check from your patch.

Which has left me wondering why did you add this check in
the first place? What was it supposed to do, and if we
drop the check, do we need some other code to achieve
the same result?

While looking into this, I've polished the patch a but
up, addressing some of the review comments from its
earlier posting, and improving error reporting. I've
attached my cleaned-up version.

Regards,

Hans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Enable-systemd-socket-activation.patch
Type: text/x-patch
Size: 4786 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131127/150d9d46/attachment.bin>