[PATCH 2/8] -pendantic is too pendantic

Ran Benita ran234 at gmail.com
Tue Nov 26 15:33:17 PST 2013


On Wed, Nov 06, 2013 at 07:45:39PM -0800, Keith Packard wrote:
> Many system headers have warnings when compiled with this flag.

This was already committed, but how about changing to AC_CC_C99 instead?
pedantic _can_ be useful for XCB imo, e.g. the "enum too big for an int"
thing. Also, the code already uses some C99 constructs now.

> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6c107bc..4a30584 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -128,7 +128,7 @@ xcbincludedir='${includedir}/xcb'
>  AC_SUBST(xcbincludedir)
>  
>  if  test "x$GCC" = xyes ; then
> -    CWARNFLAGS="-Wall -pedantic -Wpointer-arith -Wold-style-definition \
> +    CWARNFLAGS="-Wall -Wpointer-arith -Wold-style-definition \
>  		-Wstrict-prototypes -Wmissing-declarations -Wnested-externs"
>  else
>      AC_CHECK_DECL([__SUNPRO_C], [SUNCC="yes"], [SUNCC="no"])
> -- 
> 1.8.4.2
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel


More information about the xorg-devel mailing list