[PATCH xf86-video-modesetting 1/2] Staticise output names

Aaron Plattner aplattner at nvidia.com
Mon Nov 25 09:05:18 PST 2013


On 11/25/13 03:49, Thierry Reding wrote:
> This array isn't used anywhere outside this file, so it can be made
> static.
>
> Signed-off-by: Thierry Reding <treding at nvidia.com>
> ---
>   src/drmmode_display.c | 32 ++++++++++++++++----------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 773ec4c1c441..9965409a0307 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -961,22 +961,22 @@ static int subpixel_conv_table[7] = { 0, SubPixelUnknown,
>   				      SubPixelVerticalBGR,
>   				      SubPixelNone };
>
> -const char *output_names[] = { "None",
> -			       "VGA",
> -			       "DVI",
> -			       "DVI",
> -			       "DVI",
> -			       "Composite",
> -			       "S-video",
> -			       "LVDS",
> -			       "CTV",
> -			       "DIN",
> -			       "DisplayPort",
> -			       "HDMI",
> -			       "HDMI",
> -			       "TV",
> -			       "eDP",
> -			       "Virtual"
> +static const char *output_names[] = { "None",

While you're at it, can you make it static const char *const as well?

> +				      "VGA",
> +				      "DVI",
> +				      "DVI",
> +				      "DVI",
> +				      "Composite",
> +				      "S-video",
> +				      "LVDS",
> +				      "CTV",
> +				      "DIN",
> +				      "DisplayPort",
> +				      "HDMI",
> +				      "HDMI",
> +				      "TV",
> +				      "eDP",
> +				      "Virtual",
>   };
>
>   static void
>



More information about the xorg-devel mailing list