[PATCH 01/14] present: Disable when Xinerama is active

[walter harms]

Am 21.11.2013 23:43, schrieb Adam Jackson:
> Among much else Present depends on RANDR types, and RANDR isn't properly
> Xinerama-aware yet anyway.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  present/present_screen.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/present/present_screen.c b/present/present_screen.c
> index 2702cd6..25ef681 100644
> --- a/present/present_screen.c
> +++ b/present/present_screen.c
> @@ -206,6 +206,11 @@ present_extension_init(void)
>      ExtensionEntry *extension;
>      int i;
>  
> +#ifdef PANORAMIX
> +    if (!noPanoramiXExtension)
> +        return;
> +#endif
> +
>      extension = AddExtension(PRESENT_NAME, PresentNumberEvents, PresentNumberErrors,
>                               proc_present_dispatch, sproc_present_dispatch,
>                               NULL, StandardMinorOpcode);



Just a minor question,
would it be better to set noPanoramiXExtension depending on PANORAMIX ? So you can get rid of that #ifdef stuff.

A simple hint:
The name of the variable is bad. People are notoriously bad with negations. Perhaps you can rename that into
have_PanoramiXExtension (or something like that) ?

just my 2 cents,
 wh