[PATCH 00/37] Warning fixes (post 1.15 proposed changes)

[Adam Jackson]

On Sun, 2013-11-17 at 00:01 -0800, Keith Packard wrote:

>  1) Handle string constants by declaring lots of stuff as
>     'const char *'. We use string constants all over the server,
>     and carelessly store them in 'char *' variables. This introduces
>     lots of potential for accidentially trying to smash them. I'm
>     afraid I didn't actually find any obvious bugs in all of these
>     changes though.

I'm not totally happy with this.  Casting away const on the argument to
free() potentially hides bugs, because the point is you _shouldn't_ be
able to free() things in .rodata, ie, actually constant values.

- ajax