[PATCH 0/2] Don't use xshmfence unless supported by the driver

Mark Kettenis mark.kettenis at xs4all.nl
Wed Nov 20 01:26:38 PST 2013


> From: Keith Packard <keithp at keithp.com>
> Date: Tue, 19 Nov 2013 22:36:50 -0800
> 
> Keith Packard <keithp at keithp.com> writes:
> 
> > This makes the xshmfence stuff only used if the driver specifies it,
> > allowing drivers to specify other FD-passing based fences, and also
> > avoiding errors if a driver doesn't initialize any FD-passing based
> > fences.
> >
> > Without these changes, the X server will crash when an application
> > creates an xshmfence object and passes that to the X server to a
> > driver that has no DRI3 FD passing support.
> 
> I'd love to see if anyone wants to give this patch a try, or at least
> look over it. It's a serious bug in the X server that applications
> using the DRI3 extension incorrectly can currently crash X.
> 
> RC coming out on Friday, the last before the minor bug window closes
> next week.

Keith, can you please fix the xshmfence API to use either 'void *' or
an opaque 'struct xshmfence *' instead of 'int32_t *' before we have
to leave with this design mistake forever?


More information about the xorg-devel mailing list