[PATCH 29/37] xfree86/dri: Mark DRIDrvMsg and dri_drm_debug_print as gnu_printf. Fix resulting warnings.

Alan Coopersmith alan.coopersmith at oracle.com
Sun Nov 17 09:23:22 PST 2013


On 11/17/13 12:01 AM, Keith Packard wrote:
> Signed-off-by: Keith Packard <keithp at keithp.com>
> ---
>   hw/xfree86/dri/dri.c | 30 ++++++++++++++++++------------
>   1 file changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c
> index 6292e87..959288d 100644
> --- a/hw/xfree86/dri/dri.c
> +++ b/hw/xfree86/dri/dri.c
> @@ -100,6 +100,9 @@ drmServerInfo DRIDRMServerInfo;
>    * easily changed here.
>    */
>   #define DRI_MSG_VERBOSITY 1
> +#if defined(__GNUC__) && (__GNUC__ > 3)
> +__attribute__((format(gnu_printf, 3, 4)))
> +#endif

Why not use _X_ATTRIBUTE_PRINTF from <X11/Xfuncproto.h> like all the existing
uses in the X server code?   It already has the right compiler/version checks
built in.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list