[PATCH] Stop including inline assembly .il file for Solaris Studio builds

Keith Packard keithp at keithp.com
Wed Nov 13 18:53:18 PST 2013


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Since all the inb/outb/etc. use in the X server itself (except for
> xf86SlowBcopy) has been replaced by calls to libpciaccess, we no
> longer need to pass inline assembly files to replace the gcc inline
> assembly from hw/xfree86/common/compiler.h when building Xorg itself.
>
> The .il files are still generated and installed in the SDK for the
> benefit of drivers who may use them.
>
> Binary diff of before and after showed that xf86SlowBcopy was the
> only function changed across the Xorg binary and all modules built
> in the Xserver build, it just calls the outb() function now instead
> of having the outb instructions inlined, making it a slightly slower
> bcopy.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

This looks reasonable, but I haven't any way to test it...

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131114/9f6a78ba/attachment.pgp>


More information about the xorg-devel mailing list