[PATCH RESEND] xfree86: Find primary entity when bus types are nominally different

Jeremy Huddleston Sequoia jeremyhu at freedesktop.org
Fri Nov 8 14:49:42 PST 2013


This breaks Xorg builds on systems without libpci.

This is also on server-1.14-branch post 1.14.4, so we need to get this fixed up on the stable branch too.

xf86Bus.c:270:9: error: incomplete definition of type 'struct pci_device' [Semantic Issue]
        return MATCH_PCI_DEVICES(pEnt->bus.id.pci, primaryBus.id.plat->pdev);
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

On Oct 29, 2013, at 9:50, Keith Packard <keithp at keithp.com> wrote:

> Connor Behan <connor.behan at gmail.com> writes:
> 
>> As of server 1.13, systems with DRM and Udev will have BUS_PLATFORM as
>> their primary bus type. However, drivers not implementing a
>> platformProbe function will still create entities of type BUS_PCI. We
>> need to account for this when checking for the primary entity.
> 
> Merged.
>   b32a4c9..04ab07c  master -> master
> 
> -- 
> keith.packard at intel.com
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4154 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131108/1cfaee8d/attachment-0001.bin>


More information about the xorg-devel mailing list