[Xcb] [PATCH 5/7] Add event queue splitting

[Keith Packard]

Uli Schlachter <psychon at znc.in> writes:

> With google I found the patches in question and looked at them quickly. My first
> impression is that the xcb_*_special_event() functions might need way better
> documentation.

That's always true :-)

> Also, this adds public API that allows to "hide" XGE events from the "normal"
> APIs for getting events. Since this seems to be written just with present in
> mind, I can see why it is done like this, but if we really want to go down that
> road, I don't see why this should be XGE-specific.

It's XGE-specific because of the need to match events with hard-coded
logic in the library, rather than using a call-back mechanism which has
proven difficult to make thread-safe in other libraries.

> Since this is public API, we should IMHO think thrice before settling
> on something.

We've never been able to use XCB for OpenGL. This provides a minimal
mechanism that makes it possible to do that, with no additional
threading complexity within XCB.

Adding future APIs to filter events in new ways is quite possible, now
that we have the general notion of separate event queues.

The one thing we might change is the name of the function which creates
a special event queue which matches XGE events. Other than that, further
API additions which allow for more general event matching are left to
future XCB releases, none of that will impact the APIs proposed.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131106/014c381a/attachment-0001.pgp>