[PATCH 5/7] Add event queue splitting

Peter Harris pharris at opentext.com
Wed Nov 6 11:34:03 PST 2013


On 2013-11-05 19:41, Keith Packard wrote:
> This allows apps to peel off certain XGE events into separate queues
> for custom handling. Designed to support the Present extension
> 
> Signed-off-by: Keith Packard <keithp at keithp.com>

Re: xcb_register_for_special_event, xcb_unregister_for_special_event,
xcb_check_for_special_event, and xcb_wait_for_special_event.

There was some push-back the last time something similar to this came
up, on the theory that it should be in a separate library from xcb[1].
That said, we may have reached the point where it's just too useful to
not have in libxcb.

Does this interface work for the rest of the things needed for GLX?

Adding Josh Tripplett to the CC list.

> diff --git a/src/xcb.h b/src/xcb.h
> index f7dc6af..f99e677 100644
> --- a/src/xcb.h
> +++ b/src/xcb.h
> @@ -138,23 +138,6 @@ typedef struct {
>  } xcb_generic_event_t;
>  
>  /**
> - * @brief GE event
> - *
> - * An event as sent by the XGE extension. The length field specifies the
> - * number of 4-byte blocks trailing the struct.
> - */
> -typedef struct {
> -    uint8_t  response_type;  /**< Type of the response */
> -    uint8_t  pad0;           /**< Padding */
> -    uint16_t sequence;       /**< Sequence number */
> -    uint32_t length;
> -    uint16_t event_type;
> -    uint16_t pad1;
> -    uint32_t pad[5];         /**< Padding */
> -    uint32_t full_sequence;  /**< full sequence */
> -} xcb_ge_event_t;
> -
> -/**

This hunk doesn't appear to be related to event queue splitting. Should
it be in a separate commit?

Peter Harris

[1] http://lists.freedesktop.org/archives/xcb/2012-January/007571.html
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list