[PATCH 5/6] Add DRI3
Keith Packard
keithp at keithp.com
Wed Nov 6 10:35:50 PST 2013
Adam Jackson <ajax at nwnk.net> writes:
> There's not much semantic difference, but the protocol text says
> Drawable not Window.
Thanks, easily fixed.
> The protocol spec is ambiguous here? Section A.2 still seems to
> reference CARD32 driver_type and driver name and whatnot.
Sorry, I didn't review the DRI3 encoding as closely as I should
have. Fixed.
>> diff --git a/src/xproto.xml b/src/xproto.xml
>> index bf4dcbf..c9f6979 100644
>> --- a/src/xproto.xml
>> +++ b/src/xproto.xml
>> @@ -1080,7 +1080,24 @@ The number of keycodes altered.
>> </doc>
>> </event>
>>
>> -
>> + <event name="ge" number="35">
>> + <field type="CARD8" name="extension"/>
>> + <field type="CARD32" name="length"/>
>> + <field type="CARD16" name="evtype"/>
>> + <pad bytes="22" />
>> + <doc>
>> + <brief>generic event (with length)</brief>
>> + <field name="extension"><![CDATA[
>> +The major opcode of the extension creating this event
>> + ]]></field>
>> + <field name="length"><![CDATA[
>> +The amount (in 4-byte units) of data beyond 32 bytes
>> + ]]></field>
>> + <field name="evtype"><![CDATA[
>> +The extension-specific event type
>> + ]]></field>
>> + </doc>
>> + </event>
>
> This seems like it ought to be a separate commit.
Yes. Fixed on my branch.
> These three hunks don't seem to be wired up to anything.
I had hoped to make the 'full_sequence' stuff automagic, and these were
a few left-over dregs from that experiment.
Removed.
Thanks for your review!
--
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131106/7c9e3033/attachment.pgp>
More information about the xorg-devel
mailing list