[PATCH modular] build.sh: add presentproto, dri3proto, and libxshmfence

[Aaron Plattner]

On 11/01/2013 01:37 PM, Gaetan Nadon wrote:
> On 13-11-01 01:56 PM, Aaron Plattner wrote:
>> These new packages are needed by xserver.
>>
>> Signed-off-by: Aaron Plattner<aplattner at nvidia.com>
>> ---
>>   build.sh | 3 +++
>>   1 file changed, 3 insertions(+)
>
> I am out of context here, but these looks like prototypes from a
> packaging point of view. Could you bring them up to spec? Any other xorg
> protos and libs can be used to copy and fix up. Otherwise it would take
> dozens of patches to fix them up.

I'll try to put together some patches for this, though I'm not too 
familiar with these modules or the state of the art in autotools 
incantations.

> Everything is explained in details here:
> http://www.x.org/wiki/NewModuleGuidelines/
>
>
> .gitignore is wrong, copy the one used in any of the xorg modules
> Missing COPYING file
> missing README file
>
> libshmfence:
>
> |AC_PREREQ([2.57]) should be 2.60
> AC_FATAL is really old. Please copy the whole paragraph from any modules already in build.sh
>
> Don't set AC_PROG_CC, bad.
> Don't write XORG_CWARNFLAGS in configure.ac.
>
> This is bad too:
> |
> ||XORG_RELEASE_VERSION
> XORG_CHANGELOG|
> |
>
> Missing:
>
> |XORG_MACROS_VERSION(1.3)
> XORG_DEFAULT_OPTIONS|
>
> This use of AC_OUTPUT is deprecated use AC_CONFIG_FILES
>
> The Makefile.am does need to put ChangeLog in EXTRA_DIST
> Copy the snippet from another module.
>
> This code is really ancient. Please copy from any lib xorg has shipped
> recently.
>
> I'll be happy to review the changes and help if anything is unclear, but
> it should only take a few minutes to fix.
>


-- 
Aaron