[PATCH 1/2] Remove 'Readv' interface

[Keith Packard]

Mark Kettenis <mark.kettenis at xs4all.nl> writes:

>> From: Keith Packard <keithp at keithp.com>
>> Date: Fri, 01 Nov 2013 01:50:21 -0700
>> 
>> Mark Kettenis <mark.kettenis at xs4all.nl> writes:
>> 
>> >> From: Keith Packard <keithp at keithp.com>
>> >> Date: Thu, 31 Oct 2013 13:10:24 -0700
>> >>=20
>> >> No-one uses this, so there's no reason for it to be in the library
>> >
>> > I don't really think it makes sense to remove Readv but keep Writev.
>> > It's not that you're removing a significant amount of code...
>> 
>> I removed it because I didn't want to have to add fd passing support to
>> that function. However, writev is still being used, so I did fix that
>> interface.
>
> Unfortunately your statement that Readv isn't used seems to be false.
> There is a call to _FSTransReadv in libFS/src/FSlibInt.c.

Always forgetting the horrid font server library. I guess I could just
stick the non-FD passing Readv back into xtrans, but that seems wrong
too. Or just create a fake Readv that calls the regular read.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131101/2db8c842/attachment.pgp>