[RFC][PATCH] Make GetXIDRange O(1) instead of O(N^2)

Roberto Ragusa mail at robertoragusa.it
Tue May 28 00:15:01 PDT 2013

On 05/28/2013 06:35 AM, Jamey Sharp wrote:
> I can't give this a full review, but off-hand it seems like a good idea to me!


> You'll want to be careful about the indentation in your patch when you put the final version together for review. This version has several different indentation levels throughout.


the bizarre indentation levels are sometimes used to separate
clean parts from dirty parts (repeated prototypes, debug code, ...).
This is mostly a proof of concept to receive feedback, I would
never submit something in that shape for merging. ;-)
(as I already wrote in the first sentences of my mail).

I hope someone can explain the ID reuse stuff. I'm not able to say
what applications rely on this, but I can say that in my first
implementation I assumed one add and one free for each ID and the
KDE desktop was not able to start (and fluxbox too, IIRC).

   Roberto Ragusa    mail at robertoragusa.it

More information about the xorg-devel mailing list