[PING PATCH xaw3d 0/2] Xaw3d build system

Javier Pello javier.pello at urjc.es
Mon May 20 05:18:54 PDT 2013


There is no maintainer for libXaw3d listed in


The first patch fixes a real bug in the build system.

> I am attaching a couple of patches to the Xaw3d build system.
> The first patch deals with a bug when running configure. Xaw3d has
> several optional features (multiplane bitmaps, gray stipples, arrow
> scrollbars), disabled by default, that can be selected at configure
> time via --enable-foo switches. However, if you pass an explicit
> --disable-foo switch, configure will actually *enable* the feature,
> which, in my opinion, breaks the principle of least astonishment.
> The first patch corrects this.
> The second patch restores recording of such compilation options in
> Xaw3dP.h. In 1.5, features selected at configure time (multiplane
> bitmaps, etc.) were recorded as defines in Xaw3dP.h, so packages
> compiling against Xaw3d could check those defines by including
> Xaw3dP.h to see what features were enabled. This has now changed,
> and, as I understand it, detection of optional features should be
> done by the additional -Dfoo flags reported by `pkgconfig --cflags
> xaw3d`. This, however, breaks compilation of old packages against
> version 1.6, since they no longer find the defines where they expect
> them to be (in Xaw3dP.h), and know nothing about a .pc file. It would
> be nice (and easy) to keep backwards API compatibility for those old
> packages by restoring the defines in Xaw3dP.h.
> Javier Pello (2):
>   Fix --enable-feature options in configure
>   Restore recording of build options in Xaw3dP.h
>  .gitignore                                  |  1 +
>  configure.ac                                | 31 +++++++++++++++++++++--------
>  include/Makefile.am                         |  4 +++-
>  include/X11/Xaw3d/{Xaw3dP.h => Xaw3dP.h.in} |  8 ++++----
>  4 files changed, 31 insertions(+), 13 deletions(-)
>  rename include/X11/Xaw3d/{Xaw3dP.h => Xaw3dP.h.in} (94%)
> -- 1.8.2

More information about the xorg-devel mailing list