[PATCH] dix: devices must have valuators before touch is initialized

Peter Hutterer peter.hutterer at who-t.net
Mon May 13 15:31:19 PDT 2013


Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
---
This used to return False before 2f1aedcaed8fd99b823d451bf1fb02330c078f67
but I misssed changing that condition. So now it breaks make check
because InitTouchClassDeviceStruct requires the valuators to be set up.

 dix/devices.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dix/devices.c b/dix/devices.c
index c514d77..c514cfe 100644
--- a/dix/devices.c
+++ b/dix/devices.c
@@ -1647,6 +1647,7 @@ InitTouchClassDeviceStruct(DeviceIntPtr device, unsigned int max_touches,
 
     BUG_RETURN_VAL(device == NULL, FALSE);
     BUG_RETURN_VAL(device->touch != NULL, FALSE);
+    BUG_RETURN_VAL(device->valuator == NULL, FALSE);
 
     /* Check the mode is valid, and at least X and Y axes. */
     BUG_RETURN_VAL(mode != XIDirectTouch && mode != XIDependentTouch, FALSE);
-- 
1.8.1.4



More information about the xorg-devel mailing list