[PULL] unreviewed patches

[Peter Hutterer]

On Mon, May 06, 2013 at 11:26:10AM -0700, Keith Packard wrote:
> Peter Hutterer <peter.hutterer at who-t.net> writes:
> 
> >       Xi: fix comment - XI2 grabs aren't keysym grabs
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       dix: send the current axis value in DeviceChangedEvents (#62321)
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       Xi: always return BadMatch for XTest devices ChangeDeviceControl requests
> 
> (this appears to cover all of the DDX entry points to avoid passing
> XTest devices to them)
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       If neither HAL nor udev backends are enabled, warn the user
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       xkb: free XkbRulesUsed and XkbRulesDflt on extension cleanup
> 
> I think this should be done in CloseDownDevices -- XkbDeleteRulesDflts
> is already called there, adding a call to your new XkbDeleteRulesUsed
> (which looks fine, btw) seems like the right plan.

moved there. I assumed your rev-by, I don't want to do another revision. let
me know if it's not to your liking.

> 
> >       Delete callbacks when extension are closed
> >       dix: delete all callbacks before reset
> 
> Looks like the second patch makes the first unnecessary?

yes, but tbh I do like the idea of extensions cleaning up after themselves
instead of leaving it to some other piece of code. I can drop the patch
though, I don't care either way tbh.

Cheers,
   Peter

> >       dix: reset the registry before quitting
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       os: support pnprintf length modifiers for integers
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       os: support %% in pnprintf
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       os: support %c in pnprintf
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       os: complain about unsupported pnprintf directives
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> >       os: Use ErrorFSigSafe from FatalError and it's friends
> 
> Reviewed-by: Keith Packard <keithp at keithp.com>
> 
> -- 
> keith.packard at intel.com