[PATCH 1/7] Xi: return !Success from DeliverTouchEmulatedEvent if we didn't deliver
Keith Packard
keithp at keithp.com
Mon Mar 18 16:42:34 PDT 2013
Peter Hutterer <peter.hutterer at who-t.net> writes:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
Ok, this took more review than I would have though. Changing the return
value assumes that all callers will be happy with the new value, in this
case, I'm betting that no-one actually uses the value at this
point. Here's an inverse call graph:
DeliverTouchEmulatedEvent
DeliverEmulatedMotionEvent Ignores value
DeliverTouchBeginEvent
DeliverTouchEvent
DeliverTouchEvents Ignores value
DeliverTouchEndEvent
DeliverTouchEvent
DeliverTouchEvents Ignores value
In no case do these functions actually look at the value, they simply
pass it up the call chain. Therefore, this patch will have 'no effect'.
Reviewed-by: Keith Packard <keithp at keithp.com>
--
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130318/65966253/attachment.pgp>
More information about the xorg-devel
mailing list