[PATCH] xf86: return NULL for xf86CompatOutput if config->compat_output is -1

Aaron Plattner aplattner at nvidia.com
Mon Mar 18 12:14:27 PDT 2013


On 03/18/2013 11:47 AM, Chris Wilson wrote:
> On Mon, Mar 18, 2013 at 11:31:59AM -0700, Keith Packard wrote:
>> Aaron Plattner <aplattner at nvidia.com> writes:
>>
>>> If there is no compat output, config->compat_output is -1 and xf86CompatOutput
>>> reads before the beginning of the outputs array.
>
> Didn't Dave send the fix for this?
> 1357701295-19913-1-git-send-email-airlied at gmail.com
> http://patchwork.freedesktop.org/patch/12803/

My server should have that commit 
(3ec35c45ca17f5ed6fd02c50fc49ae7b8d128dcb).  I'll step through it to see 
why I'm not getting a compat_output.

I checked the callers and they all look like they'll correctly handle a 
NULL return from xf86CompatOutput, but it does also look like that's not 
supposed to actually happen.

-- 
Aaron


More information about the xorg-devel mailing list