[PATCH 0/5] Various GLX fixes

[Adam Jackson]

On Thu, 2013-02-28 at 14:30 -0800, Ian Romanick wrote:
> On 02/25/2013 02:04 PM, Adam Jackson wrote:
> > GLX's GetDrawableAttributes request works by simply dumping all the attributes
> > the server knows about to the client, and filtering on the client side.  Sadly
> > we only ever bothered to implement enough of that to make texture_from_pixmap
> > work.  This series fills in the rest of the bits that GLX 1.3 requires, and
> > then fixes an obvious sanity check bug around CreatePixmap.
> >
> > This _doesn't_ fix piglit's tests for glXQueryDrawable as currently written,
> > because that test uses the GLX 1.2 API where Windows are always treated as
> > valid GLX drawables, and that path seems to be a bit funny at the moment.  In
> 
> This sounds like we should add some tests.  If there's functionality 
> required by GLX 1.4, we should have a test that uses the expected GLX 
> 1.4 functions.  Whether or not this means the existing test should be 
> removed is, I think, another discussion.
> 
> I like it when bug fixes make tests change from failing to passing. :)

Your wish is my command:

To ssh://git.freedesktop.org/git/piglit
   99055b7..131b213  master -> master

- ajax