[PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

[Thomas Dickey]

On Tue, Jun 25, 2013 at 11:02:48PM +0200, Thomas Klausner wrote:
> ---
>  src/ResConfig.c | 4 ++--
>  src/TMparse.c   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ResConfig.c b/src/ResConfig.c
> index 152d9cf..5a7f6d2 100644
> --- a/src/ResConfig.c
> +++ b/src/ResConfig.c
> @@ -892,7 +892,7 @@ _XtResourceConfigurationEH (
>  	int		actual_format;
>  	unsigned long	nitems;
>  	unsigned long	leftover;
> -	unsigned char	*data = NULL;
> +	char		*data = NULL;
>  	unsigned long	resource_len;
>  	char		*data_ptr;
>  	char		*resource;
> @@ -952,7 +952,7 @@ _XtResourceConfigurationEH (
>  		pd->rcm_data, 0L, 8192L,
>  		TRUE, XA_STRING,
>  		&actual_type, &actual_format, &nitems, &leftover,
> -		&data ) == Success && actual_type == XA_STRING
> +		(unsigned char **)&data ) == Success && actual_type == XA_STRING
>  			   && actual_format == 8) {

One problem with casts is that they're telling the compiler to ignore its type-checking.
Casting an address like that happens to work - usually - but not always.

-- 
Thomas E. Dickey <dickey at invisible-island.net>
http://invisible-island.net
ftp://invisible-island.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130626/efe088e2/attachment.pgp>