[PATCH:xrandr 2/2] Use __UNCONST to work around const problem.

Thomas Klausner wiz at NetBSD.org
Wed Jun 12 02:50:56 PDT 2013


On Thu, Jun 06, 2013 at 11:23:00PM -0700, Alan Coopersmith wrote:
> On 06/ 2/13 05:15 PM, Thomas Klausner wrote:
> >On Mon, Jun 03, 2013 at 01:37:31AM +0200, Thomas Klausner wrote:
> >>On Sun, Jun 02, 2013 at 04:35:51PM -0700, Alan Coopersmith wrote:
> >>>On 06/ 2/13 12:30 PM, Thomas Klausner wrote:
> >>>>XXX: should probably be fixed differently.
> >>>>---
> >>>>  xrandr.c | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>>diff --git a/xrandr.c b/xrandr.c
> >>>>index da786cb..0b285a3 100644
> >>>>--- a/xrandr.c
> >>>>+++ b/xrandr.c
> >>>>@@ -1524,7 +1524,7 @@ crtc_set_transform (crtc_t *crtc, transform_t *transform)
> >>>>      if (major > 1 || (major == 1 && minor >= 3))
> >>>>  	XRRSetCrtcTransform (dpy, crtc->crtc.xid,
> >>>>  			     &transform->transform,
> >>>>-			     transform->filter,
> >>>>+			     __UNCONST(transform->filter),
> >>>>  			     transform->params,
> >>>>  			     transform->nparams);
> >>>>  }
> >>Better would be if we wouldn't need the unconst cast though :)
> >
> >That's still true :)
> 
> Looks like we don't, since XRRSetCrtcTransform now takes const for that
> argument:
> 
> http://cgit.freedesktop.org/xorg/lib/libXrandr/commit/?id=6dfe7d4fa04a5054ee3daeb654ac5a763f37fed1
> 
> Try building with libXrandr 1.4.1 without this unconst-ing change.

You're right, please disregard this one.
 Thomas


More information about the xorg-devel mailing list