[PATCH] build: dont use AC_CHECK_FILE when enabling DRI

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jul 31 09:25:42 PDT 2013


On 07/31/13 09:12 AM, Ross Burton wrote:
> Automatically enabling or disabling a feature based on installed files isn't
> deterministic, and AC_CHECK_FILE returns an error when cross-compiling.
>
> Fix this by enabling DRI by default, and removing the explicit file checks as
> pkg-config is good enough.
>
> (#57606)
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>   configure.ac |   25 ++-----------------------
>   1 file changed, 2 insertions(+), 23 deletions(-)

What is this patch against?   I don't see those AC_CHECK_FILE calls in
the xserver git repo, nor in xf86-video-intel.   Doing a grep across all
the git clones I have suggests it could be xf86-video-mach64, -mga, -qxl,
-r128, -savage, -sis, -tdfx, -xgi or -xgixp.

As for the patch itself, why not use PKG_CHECK_EXISTS to set the default if
the required modules ([libdrm >= 2.0 xf86driproto]) are present?

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list