[PATCH V2 driver/xgixp] Remove symbol lists as they are not used any more

walter harms wharms at bfs.de
Wed Jul 31 01:15:21 PDT 2013



Am 31.07.2013 09:38, schrieb Egbert Eich:
> Remove symbol lists once used by the old Metrolink module
> loader to ensure that all symbols used by the driver are
> present.
> This module loader has been dropped ages ago, the function
> calls into this module loader to perform this verification
> has been dropped from this driver howver the symbol lists
> have survived - not referenced from anywhere any more.
> 
> Signed-off-by: Egbert Eich <eich at freedesktop.org>
after visual inspection
Reviewed-by:  <wharms at bfs.de>


> ---
> v2: Made comment more verbose as requested by Walter Harms <wharms at bfs.de>
> 
>  src/xgi_driver.c | 143 -------------------------------------------------------
>  1 file changed, 143 deletions(-)
> 
> diff --git a/src/xgi_driver.c b/src/xgi_driver.c
> index 8ce071b..c98fcf7 100644
> --- a/src/xgi_driver.c
> +++ b/src/xgi_driver.c
> @@ -149,149 +149,6 @@ static void xg47_setup_fb_wrap(ReadMemoryProcPtr *read_ptr,
>      WriteMemoryProcPtr *write_ptr, DrawablePtr pDraw);
>  static void xg47_finish_fb_wrap(DrawablePtr pDraw);
>  
> -
> -static const char *vgahwSymbols[] = {
> -    "vgaHWBlankScreen",
> -    "vgaHWddc1SetSpeedWeak",
> -    "vgaHWFreeHWRec",
> -    "vgaHWGetHWRec",
> -    "vgaHWGetIOBase",
> -    "vgaHWGetIndex",
> -    "vgaHWInit",
> -    "vgaHWLock",
> -    "vgaHWMapMem",
> -    "vgaHWProtect",
> -    "vgaHWRestore",
> -    "vgaHWSave",
> -    "vgaHWSaveScreen",
> -    "vgaHWSetMmioFuncs",
> -    "vgaHWUnlock",
> -    NULL
> -};
> -
> -static const char *ddcSymbols[] = {
> -    "xf86DoEDID_DDC1",
> -    "xf86DoEDID_DDC2",
> -    "xf86PrintEDID",
> -    "xf86SetDDCproperties",
> -    NULL
> -};
> -
> -static const char *i2cSymbols[] = {
> -    "xf86CreateI2CBusRec",
> -    "xf86I2CBusInit",
> -    NULL
> -};
> -
> -static const char *fbSymbols[] = {
> -#if X_BYTE_ORDER == X_BIG_ENDIAN
> -    "wfbPictureInit",
> -    "wfbScreenInit",
> -#else
> -    "fbPictureInit",
> -    "fbScreenInit",
> -#endif
> -    NULL
> -};
> -
> -static const char *xaaSymbols[] = {
> -    "XAACreateInfoRec",
> -    "XAAestroyInfoRec",
> -    "XAAFillSolidRects",
> -    "XAAGetCopyROP",
> -    "XAAGetPatternROP", 
> -    "XAAInit",
> -    "XAAScreenIndex",
> -    "XAAStippleScanlineFuncLSBFirst",
> -    "XAAOverlayFBfuncs",
> -    "XAACachePlanarMonoStipple",
> -    "XAAHelpPatternROP",
> -    NULL
> -};
> -
> -static const char *ramdacSymbols[] = {
> -    "xf86CreateCursorInfoRec",
> -    "xf86DestroyCursorInfoRec",
> -    "xf86InitCursor",
> -    NULL
> -};
> -
> -static const char *drmSymbols[] = {
> -    "drmGetInterruptFromBusID",
> -    "drmCtlInstHandler",
> -    "drmCtlUninstHandler",
> -    "drmCommandNone",
> -    "drmCommandRead",
> -    "drmCommandWrite",
> -    "drmCommandWriteRead",
> -    "drmFreeVersion",
> -    "drmGetLibVersion",
> -    "drmGetVersion",
> -    "drmMap",
> -    "drmUnmap",
> -    NULL
> -};
> -
> -static const char *driSymbols[] = {
> -    "DRICloseScreen",
> -    "DRICreateInfoRec",
> -    "DRIDestroyInfoRec",
> -    "DRIFinishScreenInit",
> -    "DRIGetContext",
> -    "DRIGetDeviceInfo",
> -    "DRIGetSAREAPrivate",
> -    "DRILock",
> -    "DRIQueryVersion",
> -    "DRIScreenInit",
> -    "DRIUnlock",
> -    "DRICreatePCIBusID",
> -    NULL
> -};
> -
> -static const char *vbeSymbols[] = {
> -    "VBEInit",
> -    "VBEDPMSSet",
> -    "vbeDoEDID",
> -    "vbeFree",
> -    NULL
> -};
> -
> -static const char *int10Symbols[] = {
> -    "xf86ExecX86int10",
> -    "xf86FreeInt10",
> -    "xf86InitInt10",
> -    NULL
> -};
> -
> -static const char *shadowSymbols[] = {
> -    "shadowInit",
> -    NULL
> -};
> -
> -static const char *fbdevHWSymbols[] = {
> -    "fbdevHWInit",
> -    "fbdevHWUseBuildinMode",
> -    "fbdevHWGetLineLength",
> -    "fbdevHWGetVidmem",
> -    "fbdevHWDPMSSet",
> -    /* colormap */
> -    "fbdevHWLoadPaletteWeak",
> -    /* ScrnInfo hooks */
> -    "fbdevHWAdjustFrameWeak",
> -    "fbdevHWEnterVT",
> -    "fbdevHWLeaveVT",
> -    "fbdevHWModeInit",
> -    "fbdevHWRestore",
> -    "fbdevHWSave",
> -    "fbdevHWSwitchModeWeak",
> -    "fbdevHWValidModeWeak",
> -    "fbdevHWMapMMIO",
> -    "fbdevHWMapVidmem",
> -    "fbdevHWUnmapMMIO",
> -    "fbdevHWUnmapVidmem",
> -    NULL
> -};
> -
>  #ifdef XSERVER_LIBPCIACCESS
>  #define XGI_DEVICE_MATCH(d, i) \
>      { 0x18ca, (d), PCI_MATCH_ANY, PCI_MATCH_ANY, 0, 0, (i) }


More information about the xorg-devel mailing list