[PATCH:xf86-input-keyboard 13/21] Fix a shadowing warning, and add const.

Thomas Klausner wiz at NetBSD.org
Mon Jul 29 00:04:30 PDT 2013


On Sat, Jul 27, 2013 at 11:22:03AM -0700, Alan Coopersmith wrote:
> On 07/27/13 12:17 AM, Thomas Klausner wrote:
> >No. I just took the patch as committed, but you're right, const for
> >both makes more sense -- attached.
> >
> >@@ -321,11 +321,10 @@
> >
> >WSReadInput(InputInfoPtr·pInfo)
> >}
> >static·void
> >-printWsType(char·*type,·char·*devname)
> >+printWsType(const·char·*type,·const·char·*name)
> >{
> >-····xf86Msg(X_PROBED,·"%s:·Keyboard·type:·%s\n",·devname,·type);·
> >+····xf86Msg(X_PROBED,·"%s:·Keyboard·type:·%s\n",·name,·type);
> >}
> >#endif
> 
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Thanks!

Do I add this and the other "Reviewed-by" with 'git amend' to my patch
set manually, or is there a better way?
 Thomas


More information about the xorg-devel mailing list