[PATCH libxtrans v3.2] Enable systemd socket activation

Alan Coopersmith alan.coopersmith at oracle.com
Tue Jul 16 08:11:53 PDT 2013


On 07/16/13 12:40 AM, l.stelmach at samsung.com wrote:
> It was <2013-07-15 pon 17:20>, when walter harms wrote:
>
>> can defined(AF_INET6) happen without defined(IPv6) ?
>
> Probably no. However, define(IPv6) need not to be true everytime
> defined(AF_INET6) is. I can't say anything more, except that this is how
> it is used everywhere else in the code.

IPv6 is defined by the X build system if the person building the package
has chosen to enable IPv6 support.

AF_INET6 is defined by the OS if it provides IPv6 support.

IPv6 support should be built if it is both requested by the builder and
available from the OS.  At the time IPv6 support was added to X, it was
still being built via statically configured Imake files, so we couldn't
vary the IPv6 definition based on the OS support level, and some OS'es
allowed users to choose whether to build the OS with IPv6 support or not,
so checking both defines was the best way we came up with at the time.

If we were to spend time redesigning this today, we'd probably just drop
both defines, always build IPv6 support and declare OS'es without IPv6
support to be obsolete - but since the current system is working, it's
unlikely someone is going to spend that much time on xtrans to unravel it.


-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list