[PATCH:luit 0/3] configure.ac cleanups & bug fix

Matthieu Herrb matthieu.herrb at laas.fr
Sun Jul 14 12:45:01 PDT 2013


On Sat, Jul 13, 2013 at 09:43:44AM -0700, Alan Coopersmith wrote:
> Trying to fix https://bugs.freedesktop.org/show_bug.cgi?id=47792 as
> well as cleanup some other messes in the configure script.
> 
> Works for me on Solaris, but could use confirmation on Linux, since
> that's where the bug is reported and the changes most affect.
> 
> Alan Coopersmith (3):
>   config: Add missing AC_CONFIG_SRCDIR
>   Replace hardcoded _XOPEN_SOURCE=500 with AC_USE_SYSTEM_EXTENSIONS
>   Merge overlapping AC_CHECK_HEADERS & AC_CHECK_FUNCS calls into one
>     set
> 
>  Makefile.am  |    1 -
>  configure.ac |   25 ++++++++-----------------
>  2 files changed, 8 insertions(+), 18 deletions(-)
> 

For the serie,

Reviewed-by: Matthieu Herrb <matthieu.herrb at laas.fr>

Note however that as is luit is currently broken on OpenBSD. I had to
commit a patch to OpenBSD's xenocara to disable grantpt() check in
configure.ac to avoid picking the support for it that was added to
OpenBSD 5.3. I don't know yet if it's OpenBSD grantpt code that's
broken or its use in luit.

I'll try to figure this out and send a patch. So please don't rush to
make a release (unless you have other reasons to do so).
-- 
Matthieu Herrb


More information about the xorg-devel mailing list