[PATCH:xf86-video-i740] I740_Sync is only define if HAVE_XAA_H, so limit prototype to same define.

Thomas Klausner wiz at NetBSD.org
Thu Jul 11 03:28:45 PDT 2013


On Thu, Jul 11, 2013 at 12:15:16PM +0200, Matthieu Herrb wrote:
> On Thu, Jul 11, 2013 at 11:29:55AM +0200, Thomas Klausner wrote:
> > Hi Matthieu!
> > 
> > Alan pointed out that this is nearly the same as your patch in
> > http://patchwork.freedesktop.org/patch/13855/
> > 
> > Can you please push your patch?
> 
> Sure. Can I add a Reviewed-by: header with your name ?

Yes, definitely!
 Thomas

> > 
> > Thanks,
> >  Thomas
> > 
> > On Sun, Jun 02, 2013 at 11:47:00PM +0200, Thomas Klausner wrote:
> > > ---
> > >  src/i740_dga.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/src/i740_dga.c b/src/i740_dga.c
> > > index 532d614..eb362c5 100644
> > > --- a/src/i740_dga.c
> > > +++ b/src/i740_dga.c
> > > @@ -41,10 +41,10 @@
> > >  
> > >  static Bool I740_OpenFramebuffer(ScrnInfoPtr, char **, unsigned char **, int *, int *, int *);
> > >  static Bool I740_SetMode(ScrnInfoPtr, DGAModePtr);
> > > -static void I740_Sync(ScrnInfoPtr);
> > >  static int  I740_GetViewport(ScrnInfoPtr);
> > >  static void I740_SetViewport(ScrnInfoPtr, int, int, int);
> > >  #ifdef HAVE_XAA_H
> > > +static void I740_Sync(ScrnInfoPtr);
> > >  static void I740_FillRect(ScrnInfoPtr, int, int, int, int, unsigned long);
> > >  static void I740_BlitRect(ScrnInfoPtr, int, int, int, int, int, int);
> > >  #if 0
> > > @@ -57,8 +57,8 @@ static DGAFunctionRec I740DGAFuncs = {
> > >     I740_SetMode,
> > >     I740_SetViewport,
> > >     I740_GetViewport,
> > > -   I740_Sync,
> > >  #ifdef HAVE_XAA_H
> > > +   I740_Sync,
> > >     I740_FillRect,
> > >     I740_BlitRect,
> > >  #if 0
> > > -- 
> > > 1.8.2.3
> > > 
> > > _______________________________________________
> > > xorg-devel at lists.x.org: X.Org development
> > > Archives: http://lists.x.org/archives/xorg-devel
> > > Info: http://lists.x.org/mailman/listinfo/xorg-devel
> > > 
> 
> -- 
> Matthieu Herrb


More information about the xorg-devel mailing list