[PATCH makedepend] Don't crash if an option's argument is missing

Julien Cristau jcristau at debian.org
Tue Jul 2 10:16:47 PDT 2013


On Mon, Jul  1, 2013 at 16:20:29 -0700, Alan Coopersmith wrote:

> On 07/ 1/13 10:04 AM, Julien Cristau wrote:
> >Avoid dereferencing argv[argc].
> >
> >See http://www.forallsecure.com/bug-reports/011f1a55f79a5501b36008d6ee0d40e8b6644569/
> >
> >Reported-by: Alexandre Rebert <alexandre at cmu.edu>
> >Signed-off-by: Julien Cristau <jcristau at debian.org>
> >---
> >  main.c |   16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
[...]
> 
> Code is fine, but it appears that you've used spaces on the if line &
> tabs on the fatalerr() line in each place, making the indentation look
> funny in a few spots - would be nice to do a quick global-replace to
> clean that up.
> 
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 
Fixed the whitespace and pushed, thanks for the review!

Cheers,
Julien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130702/c5f17713/attachment.pgp>


More information about the xorg-devel mailing list