[PATCH] xkb: Fix repeat behaviour of redirect and message actions

Peter Hutterer peter.hutterer at who-t.net
Mon Jan 28 19:15:06 PST 2013


On Wed, Jan 23, 2013 at 08:04:21PM +0100, wettstein509 at solnet.ch wrote:
> > are you sure about removing that last return statement? it breaks
> > compilation, so maybe you missed a hunk here?
> 
> It is ok, but I believe I should replace the
> 
>    else if (filter->keycode == keycode)
> 
> further above by just an 'else', so that the compiler notices this as
> well.  Should I send a revised patch?

yes pleas. and tbh, I was hoping for something stronger than "I believe" :)

do you have a good test-case for this one?

Cheers,
   Peter



More information about the xorg-devel mailing list