[PATCH:xev 1/2] Fix clang warnings about converting size_t to int and back again

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jan 14 23:29:45 PST 2013


xev.c:909:15: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
    int len = strlen (s);
        ~~~   ^~~~~~~~~~
xev.c:917:34: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
    if (strncmp (s, "notuseful", len) == 0) return (NotUseful);
        ~~~~~~~                  ^~~
xev.c:918:35: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
    if (strncmp (s, "whenmapped", len) == 0) return (WhenMapped);
        ~~~~~~~                   ^~~
xev.c:919:31: warning: implicit conversion changes signedness: 'int' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
    if (strncmp (s, "always", len) == 0) return (Always);
        ~~~~~~~               ^~~

Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
---
 xev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xev.c b/xev.c
index b130b2f..34a46aa 100644
--- a/xev.c
+++ b/xev.c
@@ -906,7 +906,7 @@ NULL};
 static int
 parse_backing_store (char *s)
 {
-    int len = strlen (s);
+    size_t len = strlen (s);
     char *cp;
 
     for (cp = s; *cp; cp++) {
-- 
1.7.9.2



More information about the xorg-devel mailing list