[PATCH mkfontscale] Prefer original file over symlink (v2)

Colin Harrison colin.harrison at virgin.net
Fri Jan 11 08:12:35 PST 2013


Hi,

Yes that's more elegant than an if(0) bodge that I used quickly to get me
compiling again!

Reviewed-by: Colin Harrison <colin.harrison at virgin.net>

Thanks,
Colin Harrison

> -----Original Message-----
> From: Jon TURNEY [mailto:jon.turney at dronecode.org.uk]
> Sent: 11 January 2013 15:14
> To: xorg-devel
> Cc: Egbert Eich; Colin Harrison
> Subject: Re: [PATCH mkfontscale] Prefer original file over symlink (v2)
> 
> On 03/01/2013 20:30, Egbert Eich wrote:
> > +#define PRIO(x) ((x << 1) + tprio)
> > +#ifdef DT_LNK
> > +	if (entry->d_type != DT_UNKNOWN) {
> > +	    if (entry->d_type == DT_LNK)
> > +		tprio = 0;
> > +	} else
> > +#endif
> > +	{
> > +	    if (lstat(filename, &f_stat))
> > +		goto done;
> > +	    if (S_ISLNK(f_stat.st_mode))
> > +		tprio = 0;
> > +	}
> >          if(doBitmaps)
> >              rc = bitmapIdentify(filename, &xlfd_name);
> >          else
> 
> Unfortunately, S_ISLNK isn't defined on MinGW (see [1]), so perhaps the
> attached is needed.
> 
> [1] http://tinderbox.freedesktop.org/builds/2013-01-10-
> 0020/logs/mkfontscale/




More information about the xorg-devel mailing list