support for HW_SKIP_CONSOLE breaks use by blind people

[Samuel Thibault]

Michal Suchanek, le Thu 10 Jan 2013 12:38:13 +0100, a écrit :
> >> a proper fix needs something like:
> >>
> >> 1) introduce a HW_OPEN_CONSOLE flag which is inverse of the HW_SKIP_CONSOLE flag
> >> 2) have all drivers but void and dummy set that - dummy has nice
> >> example of setting a flag
> >> 3) have the input hotplug code handle the flag in addition to the init code
> >
> > That's more or less precisely what was suggested earlier in the thread,
> > and my precise enquiry waaaay earlier: which way should input drivers
> > set the flag, since the mechanism used for video drivers does not exist
> > for input drivers.
> 
> No. What you proposed is introduce a xorg.conf option for the dummy
> driver to open the console.

Nope. My initial proposal was the contrary. And further in the thread I
proposed what I say above.

> In a latter post, however, you say setting up special configuration
> for blind users is unacceptable, and adding that option seems like a
> special configuraion to me.

See above.

> > That said, it's of course way simpler, instead of having to modify all
> > drivers, to just make video-dummy and input-void set the SKIP flag,
> 
> That's not going to work. If you do not set the flag in dummy the
> console will open whatever you set in void. The console is open on
> every driver probe starting with dummy. The HW_SKIP_CONSOLE hack
> abuses the internal knowledge of driver probing order to set the flag
> in the driver which is probed first but which is the wrong one for
> setting the flag.

Re-read the source code. The console will be opened as soon as either of
the drivers do not set the SKIP flag.

Samuel