[PATCH] os: add FatalErrorSigSafe for signal-safe logging

Peter Hutterer peter.hutterer at who-t.net
Thu Feb 14 17:27:24 PST 2013


On Thu, Feb 14, 2013 at 04:56:34PM -0800, Jamey Sharp wrote:
> On Fri, Feb 15, 2013 at 09:35:00AM +1000, Peter Hutterer wrote:
> > diff --git a/include/os.h b/include/os.h
> > index c7108a5..2bdbf95 100644
> > --- a/include/os.h
> > +++ b/include/os.h
> > @@ -655,6 +655,12 @@ FatalError(const char *f, ...)
> >  _X_ATTRIBUTE_PRINTF(1, 2)
> >      _X_NORETURN;
> >  
> > +/* XXX: DO NOT USE! Temporary */
> > +extern _X_EXPORT void
> > +FatalErrorSigSafe(const char *f, ...)
> > +_X_ATTRIBUTE_PRINTF(1, 2)
> > +    _X_NORETURN;
> > +
> 
> Out of curiosity, do you really need to _X_EXPORT it if you only want it
> used elsewhere in os/?

good point, changed it to _X_INTERNAL locally. thanks.

Cheers,
   Peter




More information about the xorg-devel mailing list