[PATCH fixesproto] CreatePointerBarrier takes a window, not a drawable

[Daniel Martin]

Hi Peter,

On Mon, Dec 03, 2012 at 03:00:01PM +1000, Peter Hutterer wrote:
> On Sun, Dec 02, 2012 at 11:54:51PM -0500, Jasper St. Pierre wrote:
> > You should probably rename the 'drawable' field to 'window'.
> 
> whoops, yes, of course. done locally. thanks

looks like you've forgotten to send the it to the list.

Will this end up in a minor version bump?


Cheers, Daniel

> > On Sun, Dec 2, 2012 at 11:53 PM, Peter Hutterer <peter.hutterer at who-t.net>wrote:
> > 
> > > Technically this is a change in the protocol, but we've never supported
> > > anything but a Window. Also note that it's already called "window" in the
> > > wire struct.
> > >
> > > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > > ---
> > > I also suspect that the number of compatible X11 implementations that
> > > provide support for fixes 5.0/pointer barriers is small enough that this
> > > change in protocol goes by unnoticed.
> > >
> > >  fixesproto.txt | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/fixesproto.txt b/fixesproto.txt
> > > index 5903ac9..1828ba8 100644
> > > --- a/fixesproto.txt
> > > +++ b/fixesproto.txt
> > > @@ -606,13 +606,13 @@ essentially the same reason.
> > >  CreatePointerBarrier
> > >
> > >                 barrier:                    BARRIER
> > > -               drawable:                   DRAWABLE
> > > +               drawable:                   Window
> > >                 x1, y2, x2, y2:             INT16
> > >                 directions:                 CARD32
> > >                 devices:                    LISTofDEVICEID
> > >
> > >         Creates a pointer barrier along the line specified by the given
> > > -       coordinates on the screen associated with the given drawable.  The
> > > +       coordinates on the screen associated with the given window.  The
> > >         barrier has no spatial extent; it is simply a line along the left
> > >         or top edge of the specified pixels.  Barrier coordinates are in
> > >         screen space.
> > > --
> > > 1.7.11.7