[PULL] unreviewed patches Jan 2013

Keith Packard keithp at keithp.com
Thu Feb 7 16:53:55 PST 2013


Peter Hutterer <peter.hutterer at who-t.net> writes:

> Peter Hutterer (14):
>       test/signal-logging: simplify tests using sprintf

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: silently ignore length modifiers in pnprintf

Reviewed-by: Keith Packard <keithp at keithp.com>

>       os: add support for %f to pnprintf

(this could use some improvements to clean up rounding, but meh)

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: fix ptraccel debugging printfs

There are some gratuitous format width changes in this patch which
may not give the same result with a 'real' printf. I'd revert those
given that you ignore length modifiers entirely at this point.

>       dix: add some more info to a ptraccel debug msg

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: use BUG_RETURN_VAL for an error message

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: unify prefix for ptraccel debugging in DebugAccelF macro

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: pre-scale relative events from abs devices to desktop ratio (#31636)

So many coordinate systems, so little time.

Reviewed-by: Keith Packard <keithp at keithp.com>

>       Xext: pass the current screen to miProcessDeviceEvent() from xtest calls

Reviewed-by: Keith Packard <keithp at keithp.com>

>       Xext: if a root window is given in XTestFakeInput, move to that

The comment before the call to scale_from_screen needs updating to say
/* valuators are in screen or desktop coords */

otherwise,

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dmx: don't include dmx-config.h from xdmxconfig (#37502)

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: when shutting down slave devices, shut down xtest devices last

Would be lovely to have comments before each loop labeling what devices
they expect to shut down. Otherwise:

Reviewed-by: Keith Packard <keithp at keithp.com>

>       dix: support the transformation matrix for relative devices.

I suggest leaving the current transform called 'transform' and creating
a new transform called 'relative_transform' or some such that has the
correct values in it (i.e., with the translation components set to zero
so you don't have to copy each time you use it). That will preserve API
at least.

Also, this needs to bump the ABI version number.

>       Merge branch 'ptraccel-fixes' into unreviewed
>
>  Xext/xtest.c               |  12 ++-
>  dix/devices.c              |   8 +-
>  dix/getevents.c            |  72 ++++++++++++++--
>  dix/ptrveloc.c             |  40 ++++-----
>  hw/dmx/config/xdmxconfig.c |   3 -
>  include/input.h            |   1 +
>  include/inputstr.h         |   5 +-
>  include/misc.h             |   1 +
>  os/log.c                   |  19 ++++-
>  os/utils.c                 |  32 ++++++++
>  test/signal-logging.c      | 200 ++++++++++++++++++++++-----------------------
>  11 files changed, 253 insertions(+), 140 deletions(-)

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130207/eae73f14/attachment.pgp>


More information about the xorg-devel mailing list