[PATCH app-xcalc] Assume signal handlers return void, as C89 requires

Mark Kettenis mark.kettenis at xs4all.nl
Mon Dec 16 11:04:18 PST 2013


> From: Gaetan Nadon <memsize at videotron.ca>
> Date: Mon, 16 Dec 2013 13:53:13 -0500
> 
> Drops use of Imake's obsolete SIGNALRETURNSINT.
> 
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> ---
> 
> I could have changed signal_t for void, but I noticed this type name
> to be known to BSD.

Not sure what you mean by that.  I certainly can't find signal_t in
any of OpenBSD 's header files.  Anyway, this diff is:

Reviewd-by: Mark Kettenis <kettenis at openbsd.org>

Replacing signal_t with void can be done in a future diff.

>  xcalc.h |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/xcalc.h b/xcalc.h
> index 1924bf7..ad0f317 100644
> --- a/xcalc.h
> +++ b/xcalc.h
> @@ -56,11 +56,7 @@ from the X Consortium.
>  #include <X11/Xlocale.h>
>  
>  
> -#ifdef SIGNALRETURNSINT
> -#define signal_t int
> -#else
>  #define signal_t void
> -#endif
>  
>  #define kRECIP 0	/* reciprocal */
>  #define kSQR   1	/* square */
> -- 
> 1.7.9.5
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 


More information about the xorg-devel mailing list