[PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

Alberto Milone alberto.milone at canonical.com
Thu Dec 12 01:00:09 PST 2013


We only set changes on the main protocol screen as, for example
in RRSetChanged() and RRTellChanged(), therefore we should follow
the same logic when reporting that an output changed in
RROutputChanged().

This means that RRTellChanged() will then update the relevant
timestamps also when events come from gpu screens.

Reviewed-by: Dave Airlie <airlied at redhat.com>
Signed-off-by: Alberto Milone <alberto.milone at canonical.com>
---
 randr/rroutput.c |   25 ++++++++++++++++++++-----
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/randr/rroutput.c b/randr/rroutput.c
index 2b0b82f..3cc9852 100644
--- a/randr/rroutput.c
+++ b/randr/rroutput.c
@@ -31,15 +31,30 @@ RESTYPE RROutputType;
 void
 RROutputChanged(RROutputPtr output, Bool configChanged)
 {
+    /* set changed bits on the master screen only */
     ScreenPtr pScreen = output->pScreen;
 
     output->changed = TRUE;
-    if (pScreen) {
-        rrScrPriv(pScreen);
-        RRSetChanged(pScreen);
-        if (configChanged)
-            pScrPriv->configChanged = TRUE;
+    if (!pScreen)
+        return;
+
+    ScreenPtr master;
+    rrScrPriv(pScreen);
+    rrScrPrivPtr mastersp;
+
+    if (pScreen->isGPU) {
+        master = pScreen->current_master;
+        if (!master)
+            return;
+        mastersp = rrGetScrPriv(master);
     }
+    else {
+        mastersp = pScrPriv;
+    }
+
+    RRSetChanged(pScreen);
+    if (configChanged)
+        mastersp->configChanged = TRUE;
 }
 
 /*
-- 
1.7.9.5



More information about the xorg-devel mailing list