[PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

Keith Packard keithp at keithp.com
Wed Dec 11 15:44:01 PST 2013


Alberto Milone <alberto.milone at canonical.com> writes:

> I thought about it but I also thought that RRSetChanged() would get
> master anyway.
>
> The potential benefit of passing the gpu screen is that if we ever
> wanted to do something on the gpu screen in RRSetChanged() (other than
> setting screen->changed to TRUE) before getting master, we could do that.

Ah, ok. Well, then don't set 'master' in the else -- you aren't using it.

> If you think that RRSetChanged() will always just set master->changed
> (as the name of the function suggests), then I guess we should simply
> pass master instead.

No, your plan is sound, just that you've got an unused variable in the
'else' clause, which I worried was an indication of a bug.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131211/1be729a2/attachment.pgp>


More information about the xorg-devel mailing list