[PATCH] present: recursively set window pixmaps on flip

Keith Packard keithp at keithp.com
Tue Dec 10 14:15:07 PST 2013


Adam Jackson <ajax at nwnk.net> writes:

> On Tue, 2013-12-10 at 11:32 -0800, Keith Packard wrote:
>> Newly created windows inherit the pixmap of their parent, similarly,
>> reparenting a tree inherits the pixmap of the destination tree.
>> 
>> Making present preserve the invariant that unredirected windows always
>> have the same pixmap as their parent ensures that the above cases work
>> correctly.
>
> I kind of dislike the set_window_pixmap name since it's not actually
> wired up as ->SetWindowPixmap.  set_tree_pixmap might be a little
> clearer.  But this looks correct, so.

Oh, nice suggestion. I'll change the name and leave your Rb on it.

> Reviewed-by: Adam Jackson <ajax at redhat.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131210/7648fbf9/attachment.pgp>


More information about the xorg-devel mailing list