[PATCH 0/3] libxtrans + xserver: Add support for systemd socket activation

[Hans de Goede]

Hi,

On 11/29/2013 05:38 AM, Peter Hutterer wrote:
> On Thu, Nov 28, 2013 at 04:21:12PM +0100, Hans de Goede wrote:
>> Hi All,
>>
>> As I already mentioned in my self-introduction mail I'm a new member of
>> Red Hat's graphics team. One of the first things I'll be working on is
>> systemd integration, specifically support for the new systemd-logind
>> org.freedesktop.login1.Session TakeControl / TakeDevice and friends dbus
>> calls, which should allow Xorg to be able to run without root rights
>> on Linux machines with kms graphics, for detail see:
>> http://www.freedesktop.org/wiki/Software/systemd/logind/
>>
>> Since I'm working on systemd integration Peter Hutterer has asked me to take
>> a look at the (mostly) unrelated systemd socket activation patches Samsung
>> has posted a while back:
>> http://thread.gmane.org/gmane.comp.freedesktop.xorg.devel/36092/focus=37694
>>
>> I've reviewed and tested them, and done some minor cleanups to the
>> "Enable systemd socket activation" libxtrans patch. With these cleanups
>> added I believe these are ready to be pushed.
>>
>> If someone wants to give these patches a test-run themselves, here are
>> some simple test instructions:
>>
>> 1) Create a file named /etc/systemd/system/xorg.socket with the following
>> contents:
>>
>> [Unit]
>> Description=Xorg DISPLAY=:1.0 socket
>>
>> [Socket]
>> ListenStream=/tmp/.X11-unix/X1
>>
>> [Install]
>> WantedBy=sockets.target
>>
>> 2) Create a file named /etc/systemd/system/xorg.service with the following
>> contents:
>>
>> [Unit]
>> Description=Xorg DISPLAY=:1.0 Service
>>
>> [Service]
>> ExecStart=/usr/bin/Xorg :1
>>
>> [Install]
>> Also=xorg.socket
>
> are these two files something we should ship with the server (as examples,
> not install them) or with systemd?

Given that this is mostly for more embedded setups and it does not work
with xdm/gdm, I'm not sure shipping these as example is a good idea.

They won't be usable ootb in anyway, integration work will need to be done
by distros who want to use this (bypassing xdm or equivalent). I think
shipping these may do more harm then help.

I guess we could add the above to the commit msg for the xserver
configure.ac changes ?

Regards,

Hans