[PATCH util-macros] CWARNFLAGS: comment out -Wcast-qual

[Keith Packard]

Gaetan Nadon <memsize at videotron.ca> writes:

> On a full X build, this warning accounts for the 5,888 warnings on a total
> of 12,042. The line is moved to the "noisy" section of warnings.
>
> There is a discussion about the pros and cons here:
> http://lists.x.org/archives/xorg-devel/2013-November/039069.html
>
> Signed-off-by: Gaetan Nadon <memsize at videotron.ca>

Reviewed-by: Keith Packard <keithp at keithp.com>

> ---
>  xorg-macros.m4.in |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> index 2788f8f..b2f903e 100644
> --- a/xorg-macros.m4.in
> +++ b/xorg-macros.m4.in
> @@ -1631,7 +1631,6 @@ AC_LANG_CASE(
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wunused])
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wuninitialized])
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wshadow])
> -XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wcast-qual])
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wmissing-noreturn])
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wmissing-format-attribute])
>  XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wredundant-decls])
> @@ -1642,6 +1641,7 @@ XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wredundant-decls])
>  # XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wlogical-op])
>  # XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wparentheses])
>  # XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wcast-align])
> +# XORG_TESTSET_CFLAG([[BASE_]PREFIX[FLAGS]], [-Wcast-qual])
>  
>  # Turn some warnings into errors, so we don't accidently get successful builds
>  # when there are problems that should be fixed.
> -- 
> 1.7.9.5
>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20131201/90539fdb/attachment.pgp>