[PATCH 09/19] glx: Implement GLX_FBCONFIG_ID in GetDrawableAttributes

Eric Anholt eric at anholt.net
Wed Aug 21 16:42:03 PDT 2013


Adam Jackson <ajax at redhat.com> writes:

> Required by GLX 1.4, section 3.3.6, "Querying Attributes".
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  glx/glxcmds.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/glx/glxcmds.c b/glx/glxcmds.c
> index 4a343a6..553b3b6 100644
> --- a/glx/glxcmds.c
> +++ b/glx/glxcmds.c
> @@ -1892,7 +1892,7 @@ DoGetDrawableAttributes(__GLXclientState * cl, XID drawId)
>      ClientPtr client = cl->client;
>      xGLXGetDrawableAttributesReply reply;
>      __GLXdrawable *pGlxDraw;
> -    CARD32 attributes[10];
> +    CARD32 attributes[12];
>      int numAttribs = 0, error;
>  
>      if (!validGlxDrawable(client, drawId, GLX_DRAWABLE_ANY,
> @@ -1915,6 +1915,9 @@ DoGetDrawableAttributes(__GLXclientState * cl, XID drawId)
>      attributes[8] = GLX_HEIGHT;
>      attributes[9] = pGlxDraw->pDraw->height;
>      numAttribs++;
> +    attributes[10] = GLX_FBCONFIG_ID;
> +    attributes[11] = pGlxDraw->config->fbconfigID;
> +    numAttribs++;

Would be nice to see a piglit test checking that this works.  Similarly
for patch 19.  Other than that, all but patch 3 are:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20130821/79081f55/attachment.pgp>


More information about the xorg-devel mailing list